Update: improve report location for no-space-in-parens

[golopot]

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule

What changes did you make? (Give an overview)

Change the report location of no-space-in-parens. When option never, location is changed to that of the disallowed spaces. When option 'always', missing end location is added. This change fixes part of #12334, where missing end location causes VS code to render highlighting tildes in unexpected locations.

/* eslint no-space-in-parens: [2, 'never'] */
Math.random( foo)
//   ~~~~~~          vs code report location — before
//          ~        vs code report location — after
//         ~         report location — before (missing end location)
//          ~        report location — after

/* eslint no-space-in-parens: [2, 'always'] */
Math.random(foo )
//   ~~~~~~          vs code report location — before
//         ~         vs code report location — after
//         ~         report location — before (missing end location)
//         ~         report location — after

Is there anything you'd like reviewers to focus on?
No

[kaicataldo]

This mostly LGTM, thanks! Could we add some tests that have multiple spaces just so we're sure what the behavior should be then?

[kaicataldo]

LGTM, thanks!

[mdjermanovic]

LGTM, thanks! Tried in VS Code, highlighting looks good:

It might look a little strange that the locations in the messages are same for both left and right paren when there is nothing inside. Also, the message 'There should be no space before this paren' shows a location that is far from that paren. But I think it's okay.

[platinumazure]

I'll champion. This is now accepted.

[platinumazure]

Looks good to me, thanks for contributing!