New: Add no-error-on-unmatched-pattern flag (fixes #10587) #12377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add flag to prevent errors when a pattern or --ext is not matched
eslint-deprecated
bot
added
the
triage
kaicataldo
added
accepted
|
@ncraley, can you solve the conflicts here, please? I'm not a maintainer, but I think this may help get this merged soon. cc @kaicataldo |
kaicataldo
approved these changes
Nov 22, 2019
|
@arthurdenner thanks, I'll knock out those conflicts tomorrow. |
arthurdenner
approved these changes
Nov 22, 2019
platinumazure
approved these changes
Nov 22, 2019
This was referenced Jan 12, 2020
This was referenced Jan 27, 2020
feat(eslint): add errorOnUnmatchedPattern to CLIEngine Options
DefinitelyTyped/DefinitelyTyped#41889
Merged
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #10587
What changes did you make? (Give an overview)
Added a flag to prevent errors when an unquoted glob pattern or --ext is not matched.
Is there anything you'd like reviewers to focus on?
I still need to confirm behavior when combined with other CLI options (and possibly add tests for that), but wanted to go ahead and put this out for initial feedback.