Upgrade: bump inquirer to ^7.0.0 #12440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eslint-deprecated
bot
added
the
triage
platinumazure
added
cli
|
Hi @josgraha, thanks for the PR! I want to test this locally tonight, then I'll approve the changes. I'll leave this open in case others want to review. |
|
Note to merger: Commit message needs to start with "Upgrade:" |
platinumazure
approved these changes
Oct 16, 2019
kaicataldo
approved these changes
Oct 16, 2019
josgraha
force-pushed
the
security/inquirer
branch
from
1b25f77
to
cc9d7e4
Compare
|
I'm sorry folks but I misread the Snyk Issue which only applies to |
josgraha
force-pushed
the
security/inquirer
branch
from
cc9d7e4
to
643d6be
Compare
|
Hi @josgraha, thanks for following up. I think we can accept this upgrade anyway as it's pretty low risk, and dependency upgrades are something we sometimes struggle with here. So, I appreciate this contribution nonetheless. Thanks! |
g-plane
changed the title
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
Bump
inquirerpackage to^7.0.0because 6.x depends onlodash@4.17.12which has Snyk Issue[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Bump
inquirerpackage to^7.0.0because 6.x depends onlodash@4.17.12which has Snyk IssueWhat changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?