Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: improve report location for no-tabs #12471

Merged
merged 1 commit into from Oct 23, 2019
Merged

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule

What rule do you want to change?

no-tabs

Does this change cause the rule to produce more or fewer warnings?

same, this PR changes just report locations.

How will the change be implemented? (New option, new default behavior, etc.)?

new default behavior

Please provide some example code that this change will affect:

"\t\ta =\t\t\tb +\tc\t\t;\t\t"

What does the rule currently do for this code?

image

What will the rule do after it's changed?

image

What changes did you make? (Give an overview)

Report the end location in addition to the start location.

If there are successive tabs, report the end location of the last one.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 21, 2019
@mdjermanovic mdjermanovic self-assigned this Oct 21, 2019
@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Oct 21, 2019
@ilyavolodin
Copy link
Member

I think this can be done as a bug fix or maybe even a chore, instead of enhancement. 👍

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly and removed enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 23, 2019
@platinumazure
Copy link
Member

Accepting this as a bug fix.

@platinumazure platinumazure merged commit 89e8aaf into master Oct 23, 2019
@platinumazure platinumazure deleted the notabs-loc branch October 23, 2019 15:59
@platinumazure
Copy link
Member

Merged. Thanks @mdjermanovic for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants