Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Provide debug log for parser errors #12474

Merged
merged 1 commit into from Oct 21, 2019
Merged

Chore: Provide debug log for parser errors #12474

merged 1 commit into from Oct 21, 2019

Conversation

bradzacher
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

When there's an exception thrown by the parser, currently ESLint swallows this exception.
This is fine for end users, as it allows ESLint to provide a nicer experience, but can make it hard for parser developers to debug problems when reported by users.

This change simply adds a debug log message which includes the exception stack when a parser exception occurs.

That way we can just instruct users to run eslint --debug so we can get the exception stack (amongst other things) from them.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 21, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for contributing!

@ilyavolodin ilyavolodin added chore This change is not user-facing core Relates to ESLint's core APIs and features and removed triage An ESLint team member will look at this issue soon labels Oct 21, 2019
@platinumazure platinumazure merged commit 61749c9 into eslint:master Oct 21, 2019
@bradzacher bradzacher deleted the patch-1 branch October 21, 2019 23:18
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 20, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants