Docs: Add note about Node.js requiring SSL support (fixes #11413) #12475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a small note that Node.js requires SSL to be built in. While this hasn't affected many users, it's good to document in case this comes up in the future. (And the Node.js project itself did run into this as a problem.)
nzakas
added
enhancement
nzakas
changed the title
ilyavolodin
approved these changes
Oct 21, 2019
platinumazure
approved these changes
Oct 21, 2019
aladdin-add
requested changes
Oct 22, 2019
There was a problem hiding this comment.
shall the change be made in the user guide (https://github.com/eslint/eslint/blob/master/docs/user-guide/getting-started.md#installation-and-usage)?
|
Oh yeah, that’s a good idea |
|
Updated the getting started guide, too. At some point we should probably just have one location for this information, but this should be good enough for now. |
platinumazure
approved these changes
Oct 23, 2019
aladdin-add
approved these changes
Oct 23, 2019
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Adds a small note that Node.js requires SSL to be built in. While this hasn't affected many users, it's good to document in case this comes up in the future. (And the Node.js project itself did run into this as a problem.)
I also removed the notice about the npm version as we always support the npm version shipping with the supported Node.js versions.
Is there anything you'd like reviewers to focus on?