Chore: Add extra test, improve docs #12492
Conversation
eslint-deprecated
bot
added
the
triage
platinumazure
added
chore
There was a problem hiding this comment.
Thanks for the follow-up!
The performance concern is about creating all regexes for each identifier, instead of just once per context? I saw that on review, but find out that the other rules are doing the same, wasn't sure why. Perhaps I should have left a question in the review.
|
@mdjermanovic Yes, I wasn't sure about the best approach. I could create multiple regular expressions in advance which would save some cycles. I feel the rule could be even more performant if I tried to construct one regular expression with all patterns, but I'm worried about introducing bugs that way. At this point, I've only done the work requested by you in your previous review (aside from the minor issue with the test options). |
| barVar.prop = "value"; | ||
| } | ||
|
|
||
| function foo(bar) { | ||
| function foo(barrito) { |
There was a problem hiding this comment.
This variable name is amazing 😆
|
@mdjermanovic friendly ping, has your concern been addressed? 😄 |
|
Nope, I still need to fix that test. Sorry, I've been very busy. |
|
One more friendly ping |
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Follow-up to #11275 to address review comments
What changes did you make? (Give an overview)
Added some documentation examples and a valid test, based on review comments from #11275
Is there anything you'd like reviewers to focus on?
Not really.