New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: curly multi
reports single lexical declarations (fixes #11908)
#12513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
accepted
There is consensus among the team that this change meets the criteria for inclusion
autofix
This change is related to ESLint's autofixing capabilities
labels
Oct 30, 2019
kaicataldo
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
mysticatea
approved these changes
Nov 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much!
Thanks for contributing! |
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
autofix
This change is related to ESLint's autofixing capabilities
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix #11908
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo Link
What did you expect to happen?
0 errors. A block with only one statement which is a lexical declaration doesn't make much sense, but still these curly braces cannot be removed.
What actually happened? Please include the actual, raw output from ESLint.
1 error and syntax error in the fixed code.
What changes did you make? (Give an overview)
Changed the
multi
option to not report single-statement blocks if that statement is alet
,const
,function
orclass
declaration.Is there anything you'd like reviewers to focus on?
The following added
valid
test were invalid, and the autofix was producing syntax errors:The same applies to these
valid
tests with theconsistent
modifier:The following
valid
test was also invalid. This code without braces is not a syntax error in non-strict mode, but it's a legacy syntax, so the original code shouldn't be reported and auto-fixed:This
invalid
test was invalid before, it's a regression test:These two
invalid
tests with theconsistent
modifier wereinvalid
before, but in a different way. Autofix was removing braces, which was producing syntax errors. After this PR, autofix will do the opposite, put the braces around the statement that isn't in a block.That's the only case where this PR can produce more warnings (e.g. 2 instead of 1), but that can happen only in chains that already have warnings.