Update: deprecate sourceCode#isSpaceBetweenTokens()

[kaicataldo]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[X] Add something to the core
[ ] Other, please explain:

Please evaluate just the last commit. We should wait to merge this until after we land #12491. I'll rebase at that time. Adding the "do not merge" label until then.

What changes did you make? (Give an overview)
While working on #12491, noticed that sourceCode#isSpaceBetweenTokens() currently allows for nodes as well as tokens as arguments. I think that it would make sense to rename this method to isSpaceBetween() and leave the ability for it to check between nodes and tokens, as that's a useful behavior that is most likely being used by custom rules (since we use it in at least one of our core rules). We could deprecate isSpaceBetweenTokens() and leave it as an alias that calls through to isSpaceBetween() for the sake of backwards compatibility.

Is there anything you'd like reviewers to focus on?
Does this API make sense?

[kaicataldo]

TSC Summary

While fixing a bug in in sourceCode#isSpaceBetweenTokens(), I noticed that the current documentation is incorrect, also making the name of the method not quite correct.

TSC Question

In addition to the bug fix/documentation corrections in #12491, I'd like to propose we deprecate sourceCode#isSpaceBetweenTokens() to in favor of sourceCode#isSpaceBetween(). This more accurately describes the behavior, as the method currently will check between nodes as well as tokens, and better matches the names of other sourceCode methods that check between nodes or tokens.

This PR currently deprecates sourceCode#isSpaceBetweenTokens() in a backwards compatible way, having it call through to the new method.

[kaicataldo]

This was accepted at yesterday's TSC meeting.

[kaicataldo]

Duplicating the tests below for isSpaceBetweenTokens().

[kaicataldo]

This has been rebased and is ready for review.