Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unexpected autofix in prefer-const (fixes #12514) #12521

Merged
merged 1 commit into from Nov 4, 2019
Merged

Fix: unexpected autofix in prefer-const (fixes #12514) #12521

merged 1 commit into from Nov 4, 2019

Conversation

yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Nov 2, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

add id checking

Is there anything you'd like reviewers to focus on?
#12514

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 2, 2019
@g-plane g-plane added accepted There is consensus among the team that this change meets the criteria for inclusion autofix This change is related to ESLint's autofixing capabilities bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Nov 2, 2019
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit ac60621 into eslint:master Nov 4, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 4, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion autofix This change is related to ESLint's autofixing capabilities bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants