Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Report '\08' and '\09' in no-octal-escape (fixes #12080) #12526

Merged
merged 1 commit into from Nov 13, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #12080

This PR fixes two bugs in no-octal-escape, both fixes can generate more warnings:

'\
\1';

At the moment, the rule doesn't check the second and other lines of a multiline string (Online Demo Link)

What changes did you make? (Give an overview)

  • Added 0(?=[89]) to capture 0 as an octal escape sequence.
  • Added the s flag to fix the problem with multiline strings.
  • Also added some tests unrelated to these fixes.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Nov 4, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 448ff1e into master Nov 13, 2019
@platinumazure platinumazure deleted the issue12080 branch November 13, 2019 04:07
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 13, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report '\08' and '\09' in no-octal-escape
4 participants