Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve report location for object-curly-spacing #12563

Merged
merged 1 commit into from Nov 15, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain:

Change object-curly-spacing report locations.

What changes did you make? (Give an overview)

  • For missing spaces, the difference is small, the rule will now report complete loc of the curly braces instead of just loc.start.
  • For disallowed spaces, the rule will now report the location of spaces (the range that should be removed) instead of the location of curly braces. like this:

image

Is there anything you'd like reviewers to focus on?

Since this doesn't change the start line, it produces neither more nor fewer warnings, even in the case of eslint-disable-* comments.

I guess this could be accepted as a bug fix?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 13, 2019
Copy link
Member

@ilyavolodin ilyavolodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, this should be a bug fix

@ilyavolodin ilyavolodin added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Nov 14, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 40c8c32 into master Nov 15, 2019
@kaicataldo kaicataldo deleted the objectcurlyspacing-loc branch November 15, 2019 03:38
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 15, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants