Fix: no-mixed-spaces-and-tabs reports multiline strings #12566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo Link
What did you expect to happen?
No errors. Similar to how the rule ignores the content in template literals, it should ignore the content in strings.
What actually happened? Please include the actual, raw output from ESLint.
What changes did you make? (Give an overview)
Fixed the code to ignore mixed spaces and tabs in strings.
Also, the code is simplified and (should be) optimized.
Is there anything you'd like reviewers to focus on?
Refactoring, is the code equivalent to the previous version? (apart from the string fix)
column
is always same, because the capturedindex
is always0
. This doesn't affect the correctness of this rule, but it would be nice to improve the reported locations. Since this PR already has a big diff and the regexes should be changed to achieve this, it's better to do that in a separate PR.