Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: require-await crash on global await #12571

Merged
merged 1 commit into from Nov 15, 2019
Merged

Fix: require-await crash on global await #12571

merged 1 commit into from Nov 15, 2019

Conversation

bradzacher
Copy link
Contributor

@bradzacher bradzacher commented Nov 15, 2019 •
edited

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix (template)

What changes did you make? (Give an overview)

@typescript-eslint/parser allows global awaits.
This currently rule assumes that is not allowed, because espree throws a parsing error on it.

This PR just stops the rule from crashing on global await statements.

Related: typescript-eslint/typescript-eslint#1077

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 15, 2019
@bradzacher bradzacher mentioned this pull request Nov 15, 2019
Closed
@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Nov 15, 2019
platinumazure
platinumazure requested changes Nov 15, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test which will trigger the for-await-of in top-level scope? Otherwise it seems that the change in ForOfStatement might not be needed.

@bradzacher
Copy link
Contributor Author

I was being lazy. Thanks for not letting me 😄
Fixed

@kaicataldo
Copy link
Member

kaicataldo commented Nov 15, 2019 •
edited

For posterity, top-level await is stage 3 at this time and it is ESLint’s policy to fix rules that crash on stage 3 features.

kaicataldo
kaicataldo approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit fed20bb into eslint:master Nov 15, 2019
@platinumazure
Copy link
Member

Thanks for contributing!

@bradzacher bradzacher deleted the fix-require-await branch November 16, 2019 01:19
@a-tarasyuk a-tarasyuk mentioned this pull request Nov 20, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 1, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 11, 2020
Merged
Open
This was referenced Mar 26, 2020
Merged
Merged
Merged
Open
This was referenced Apr 3, 2020
Merged
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 15, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bradzacher @kaicataldo @platinumazure