New: Include node version in cache #12582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
fa93hws
changed the title
fa93hws
force-pushed
the
include-node-version-in-cache
branch
from
a0ad07a
to
640daec
Compare
kaicataldo
reviewed
Nov 21, 2019
kaicataldo
added
bug
I can add it together with the eslint version. |
kaicataldo
added
tsc agenda
|
Even though this is a core change, it’s such a small one that I don’t think it should have to go through the RFC process. That being said, I think we should bring this to the TSC. |
|
TSC Summary This PR proposes to include the Node version when hashing the cache key, ensuring that the cache is busted when consecutive linting runs are executed with different Node versions. TSC Question Should we accept this? |
|
This proposal was accepted at today's TSC meeting. |
kaicataldo
added
accepted
platinumazure
approved these changes
Dec 6, 2019
This was referenced Jan 12, 2020
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Add node version to the key used in cache.
the result from the linting is possible to be different (some rules may fail) when the node is upgraded or downgraded.
Is there anything you'd like reviewers to focus on?
N/A