no-multiple-empty-lines: Adjust reported loc

[Turbo87]

The + 1 was from a time where we warned about anything with more than one empty line, but since then the rule has become configurable. We should put the warning on the first line that breaks this rule, instead of on the first empty line.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?

no-multiple-empty-lines

Does this change cause the rule to produce more or fewer warnings?

It should produce the same number of warnings as before

How will the change be implemented? (New option, new default behavior, etc.)?

New default behavior as it should probably be considered a bug fix

Please provide some example code that this change will affect:

console.log('foo');




console.log('foo');

What does the rule currently do for this code?

it warns on all empty lines

What will the rule do after it's changed?

it warns only on the empty lines that breaks the rule (which is the third empty line for the default configuration)

What changes did you make? (Give an overview)

I adjusted the loc of the rule report to take the rule configuration into consideration

Is there anything you'd like reviewers to focus on?

nothing in particular

[jsf-clabot]

All committers have signed the CLA.

[kaicataldo]

Can you add a test that would have failed before but would pass now?

[Turbo87]

@kaicataldo done, thanks for the review :)

[kaicataldo]

I'll champion this!

[kaicataldo]

As per our process, we'll need to reach consensus by having support from three other team members. Thanks for contributing!

[Turbo87]

@kaicataldo is there anything I can do to get more eyes on this? :)

[kaicataldo]

I actually think this should be treated as a bug fix. Will mark as accepted since I was able to verify this behavior (see example in demo.

[kaicataldo]

Will leave this open for another day or two to make sure there aren't any objections from the team and, if not, will merge then. Thanks for your patience!

[kaicataldo]

Thanks for contributing to ESLint!

[Turbo87]

no, no, thank you for maintaining it! :)