Fix: wrong indent at tagged template in indent (fixes #12122)

[yeonjuan]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

[kaicataldo]

LGTM. Thank you!

[mysticatea]

I'm not sure... but I couldn't reproduce it on v6.7.2: online demo.

[mysticatea]

I could reproduce it if an interpolation exists: online demo

Therefore, I think that this bug exists around the logic of template literals rather than function calls. I'm suspecting that the indent rule doesn't set desired offsets to the tokens of TemplateElement nodes.

[yeonjuan]

@mysticatea

I'm suspecting that the indent rule doesn't set desired offsets to the tokens of TemplateElement nodes.

oh yes, It's right. I think I should change the code in this pr. thanks!

[yeonjuan]

@mysticatea
I changed the test cases, including expressions within template literals.
And I tried to set the desired offset to the token of TemplateElement but I couldn't because it makes another change in the bellow cases.

const a = 2,
    template = `
    multiline ${
    expression} template literal`; // Error; 

so, what about just add logic within the function which checking function call(same as current pr)?

[mysticatea]

I got it. In that case, I'm OK with fixing the logic of function calls.

[yeonjuan]

plz, don't merge it. I'm sorry. It needs more checks. done.

[yeonjuan]

@kaicataldo
Sorry for changing the code after review. But I realized that the previous version does not work correctly. The previous version uses tag as an offset token. It could solve the bug in a tagged template indent.

tag`
   ${a}
  `(() => {
      tag`
        ${a}
        `(() => {

    });
});

But it had problems in cases if there are member expressions with a tagged template.

tag
   .member`
   ${a}
  `(() => {

}); // expected indent, but no error.

So, I changed the code to use a token before quasi as an offset token. So now, it solves the usual tagged template indent issues. You can check it in test cases.

eslint/tests/lib/rules/indent.js

Lines 5418 to 5438 in c780efb

	{
	code: unIndent`
	foo(() => {
	tagOne\`
	multiline
	template
	literal
	\${a} \${b}
	\`(() => {
	tagTwo\`
	multiline
	template
	literal
	\`(() => {
	bar();
	});
	baz();
	});
	});
	`,

eslint/tests/lib/rules/indent.js

Lines 5518 to 5524 in c780efb

	code: unIndent`
	foo
	.bar\` template
	literal \`(() => {
	baz();
	})
	`,

I re-request a review. Sorry for wasting your efforts.

[kaicataldo]

Sorry for the delay. Still getting caught up on my notifications backlog from the holidays.

This mostly LGTM! Just one small comment about using a token to offset instead of the full node. Thank you for adding all these test cases 😃

[kaicataldo]

LGTM, thanks for working on this!