Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add suggestions for no-unsafe-negation (fixes #12591) #12609

Merged
merged 1 commit into from Dec 20, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12591

What changes did you make? (Give an overview)

Suggestions for the no-unsafe-negation rule.

Example:

code: "!a in b",
errors: [{
  message: "Unexpected negating the left operand of 'in' operator.",
  suggestions: [
    {
      desc: "Negate 'in' expression instead of its left operand. This changes the current behavior.",
      output: "!(a in b)"
    },
    {
      desc: "Wrap negation in '()' to make the intention explicit. This preserves the current behavior.",
      output: "(!a) in b"
    }
}]

Is there anything you'd like reviewers to focus on?

Messages

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Nov 27, 2019
Copy link
Member

@ilyavolodin ilyavolodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change! I think this highlights power of suggestions when applied correctly.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@btmills btmills merged commit 05f7dd5 into master Dec 20, 2019
@btmills btmills deleted the issue12591 branch December 20, 2019 20:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 19, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants