Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add tests to cover empty object options in comma-dangle #12627

Merged
merged 1 commit into from Dec 4, 2019
Merged

Chore: Add tests to cover empty object options in comma-dangle #12627

merged 1 commit into from Dec 4, 2019

Conversation

yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Dec 1, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Add test cases in comma-dangle

What changes did you make? (Give an overview)

Added test cases for covering this branch(screenshot). This PR increases test coverage for comma-dangle.
스크린샷 2019-12-01 오후 5 12 07

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 1, 2019
@platinumazure platinumazure added chore This change is not user-facing rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Dec 1, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for contributing!

@kaicataldo kaicataldo merged commit 19194ce into eslint:master Dec 4, 2019
@yeonjuan yeonjuan deleted the add-test-cases branch December 17, 2019 12:42
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 3, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants