Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: wrap {{}} in raw liquid tags to prevent interpolation #12643

Merged
merged 1 commit into from Dec 6, 2019

Conversation

kaicataldo
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes eslint/archive-website#661

What changes did you make? (Give an overview)
Due to the fact that the interpolation delimiters in the new suggestions feature match those in Liquid, the {{ }} tags here end up not rendering any output in the generated site. Wrapping them in raw tags ensured that they're rendered as a raw string.

Is there anything you'd like reviewers to focus on?
Nothing in particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 5, 2019
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Dec 5, 2019
@kaicataldo kaicataldo merged commit e9cef99 into master Dec 6, 2019
@kaicataldo kaicataldo deleted the fix-liquid-interpolation branch December 6, 2019 00:43
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 5, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site removes {{ }} message placeholders
3 participants