Update: fix counting jsx comment len in max-len (fixes #12213)

[yeonjuan]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
This pr will fix #12213.

If the comment is in the single line jsx comment, change the comment node for checking with JSXExpressionContainer.

ex)

<>
  {/* comment */}
</>

Is there anything you'd like reviewers to focus on?

[kaicataldo]

CI is failing because of the issue reported here. This has been fixed. 🎉

[kaicataldo]

Thanks for working on this! Do you mind adding some tests for cases where a JSXExpressionContainer node might contain an expression in addition to a comment?

const example = <A 
	attr={a && b /* comment */} 
></A>

const example2 = <A 
	attr={/* comment */ a && b} 
></A>

[yeonjuan]

@kaicataldo sure!

[yeonjuan]

@kaicataldo Friendly ping :)

[mdjermanovic]

Looks very good, thanks! I left two questions about some edge cases.

I think the decision to treat the whole { /* */ } as a comment only if everything incl. braces is on the same line is a good decision, since it's a minimal change in behavior.

[yeonjuan]

@kaicataldo
Thanks!. I added more test cases you mentioned.
But Maybe there would be no change in those cases compared with the actual version.

@mdjermanovic
I changed the code and commit. Thanks! :)

[mdjermanovic]

Thanks! Just some minor details

[mdjermanovic]

Looks good! Just some detail that could be missing in otherwise very comprehensive tests.

[mdjermanovic]

LGTM, thanks!

Just to note that this change can produce new warnings if someone has comments max len < code max len configured, which is probably quite rare but maybe this should be labeled as a breaking change?

/* eslint max-len: ["error", {
   code: 100,
   comments: 50
}]*/

var jsx = (
    <p>
       {/* this line will be a new error, because it becomes a comment line with > 50 characters */}
    </p>
)

[kaicataldo]

I think it's fine to accept this as a semver-minor bug fix (though, in practice I'm not sure it matters since we are merging breaking changes in preparation for v8 right now).

[kaicataldo]

LGTM, thank you!

[kaicataldo]

Thanks for contributing to ESLint!