Chore: remove bundling of ESLint during release #12676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
added
chore
kaicataldo
force-pushed
the
remove-eslint-bundle
branch
from
de9e0d9
to
a669117
Compare
kaicataldo
commented
Dec 16, 2019
| @@ -560,7 +560,7 @@ target.mocha = () => { | |||
| target.karma = () => { | |||
| echo("Running unit tests on browsers"); | |||
|
|
|||
| target.webpack(); | |||
| target.webpack("production"); | |||
There was a problem hiding this comment.
Seems like it would be better to test against the production build in our Karma tests.
ilyavolodin
approved these changes
Dec 18, 2019
This was referenced Jan 12, 2020
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Chore
What changes did you make? (Give an overview)
Now that eslint/archive-website#665 has landed, we can remove the bundling step in our release script. We should keep the bundling step for our Karma browser tests to ensure that the demo works, however.
Is there anything you'd like reviewers to focus on?
Nothing in particular!