Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: update browser build #12693

Merged
merged 1 commit into from Dec 23, 2019
Merged

Build: update browser build #12693

merged 1 commit into from Dec 23, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain: update the webpack configuration of browser tests and the online demo.

What changes did you make? (Give an overview)

This PR update our webpack configuration to not use regjsparser package as a follow up of #12662.

After this change, @babel/preset-env prints below:

Using targets:
{
  "chrome": "76",
  "edge": "18",
  "firefox": "69",
  "ios": "12.2",
  "safari": "12.1",
  "samsung": "10.1"
}

Using modules transform: auto

Using plugins:
  transform-template-literals { "ios":"12.2", "safari":"12.1" }
  transform-function-name { "edge":"18" }
  transform-dotall-regex { "edge":"18", "firefox":"69" }
  proposal-async-generator-functions { "edge":"18" }
  proposal-object-rest-spread { "edge":"18" }
  proposal-unicode-property-regex { "edge":"18", "firefox":"69" }
  proposal-json-strings { "edge":"18" }
  transform-named-capturing-groups-regex { "edge":"18", "firefox":"69" }
  syntax-dynamic-import { "chrome":"76", "edge":"18", "firefox":"69", "ios":"12.2", "opera":"63", "safari":"12.1", "samsung":"10.1" }

Using polyfills: No polyfills were added, since the `useBuiltIns` option was not set.

Is there anything you'd like reviewers to focus on?

Are the versions OK?

@mysticatea mysticatea added the infrastructure Relates to the tools used in the ESLint development process label Dec 20, 2019
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Makefile.js Show resolved Hide resolved
@kaicataldo kaicataldo merged commit 4e16957 into master Dec 23, 2019
@kaicataldo kaicataldo deleted the update-browser-build branch December 23, 2019 20:57
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants