Update: add outerIIFEBody: "off" to indent rule (fixes #11377) #12706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
added
accepted
kaicataldo
force-pushed
the
outeriifebody-off
branch
2 times, most recently
from
e507312
to
09762eb
Compare
kaicataldo
force-pushed
the
outeriifebody-off
branch
from
09762eb
to
e14dbfd
Compare
kaicataldo
force-pushed
the
outeriifebody-off
branch
from
e14dbfd
to
6130cf8
Compare
mysticatea
approved these changes
Jan 6, 2020
|
Thank you!! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #11377
What changes did you make? (Give an overview)
This PR adds the ability to set the
outerIIFEBodyto"off". This was a lot easier than I expected - the logic already allows for this, so I just needed to add the option to the JSON schema.Is there anything you'd like reviewers to focus on?
Nothing in particular!