New: no-loss-of-precision (fixes #11279) #12747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
added
accepted
not-an-aardvark
suggested changes
Jan 27, 2020
kaicataldo
changed the title
not-an-aardvark
suggested changes
Feb 1, 2020
| function isBaseTen(node) { | ||
| const prefixes = ["0x", "0X", "0b", "0B", "0o", "0O"]; | ||
|
|
||
| return prefixes.every(prefix => !node.raw.startsWith(prefix)) && |
There was a problem hiding this comment.
I think this will treat the literal 0 as octal, which is incorrect although it doesn't affect the result of the precision check.
lib/rules/no-loss-of-precision.js
Outdated
|
|
||
| return prefixes.every(prefix => !node.raw.startsWith(prefix)) && | ||
| (!node.raw.startsWith("0") || | ||
| node.raw.startsWith("0e") || |
There was a problem hiding this comment.
This will be incorrect for something like 0E5.
lib/rules/no-loss-of-precision.js
Outdated
| (!node.raw.startsWith("0") || | ||
| node.raw.startsWith("0e") || | ||
| node.raw.startsWith("0.") || | ||
| !isOctalDigitsOnly(node.raw)); |
There was a problem hiding this comment.
I think this could be simplified to:
return prefixes.every(prefix => !node.raw.startsWith(prefix)) &&
!/^0[0-7]+$/.test(node.raw)
not-an-aardvark
approved these changes
Feb 8, 2020
webOS101
reviewed
Feb 29, 2020
|
@kaicataldo has your concerns been addressed? |
nzakas
approved these changes
May 20, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ X] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#11279
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
Nope