Chore: Adopt eslint-plugin/require-meta-docs-description internally
#12762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
bmish
changed the title
internal-rules/consistent-docs-description with eslint-plugin/require-meta-docs-descriptioninternal-rules/consistent-docs-description with eslint-plugin/require-meta-docs-description
bmish
force-pushed
the
eslint-plugin-require-meta-docs-description
branch
from
2b12661
to
7d172da
Compare
bmish
changed the title
internal-rules/consistent-docs-description with eslint-plugin/require-meta-docs-descriptioneslint-plugin/require-meta-docs-description internally
bmish
force-pushed
the
eslint-plugin-require-meta-docs-description
branch
from
7d172da
to
54cf0e0
Compare
|
I'm not sure this is the right course of action since I could see us wanting to reserve the right to easily validate internal rules differently than custom plugin rules. |
kaicataldo
added
chore
|
@kaicataldo I hear that. But I would note that:
|
|
Thanks for providing more context around that. Your reasoning makes sense to me! |
bmish
force-pushed
the
eslint-plugin-require-meta-docs-description
branch
from
54cf0e0
to
5735c98
Compare
Replaced by `eslint-plugin/require-meta-docs-description`: https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-docs-description.md
bmish
force-pushed
the
eslint-plugin-require-meta-docs-description
branch
from
5735c98
to
3ab3135
Compare
not-an-aardvark
approved these changes
Jan 27, 2020
|
@kaicataldo Just want to make sure your concerns around merging this have been addressed-- if so, this can probably be merged. Thanks! |
|
Thanks for contributing to ESLint! |
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
…eslint#12762) * Upgrade: eslint-plugin-eslint-plugin to 2.2.1 https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/CHANGELOG.md#v221-2020-01-17 * Chore: enable `eslint-plugin/require-meta-docs-description` rule internally https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-docs-description.md * Chore: delete `internal-rules/consistent-docs-description` Replaced by `eslint-plugin/require-meta-docs-description`: https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-docs-description.md
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
What changes did you make? (Give an overview)
This PR replaces the
internal-rules/consistent-docs-descriptionlint rule with eslint-plugin/require-meta-docs-description. Why?Is there anything you'd like reviewers to focus on?
Feel free to double-check that the replacement rule has the same behavior as the deleted rule.