Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Check flatMap in array-callback-return (fixes #12235) #12765

Merged
merged 1 commit into from Jan 17, 2020

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12235

What changes did you make? (Give an overview)

Updated array-callback-return to check .flatMap() callbacks as well.

Is there anything you'd like reviewers to focus on?

There are no specific conditions such as ecmaVersion >= 10. The rule treats flatMap same as all other targeted methods.

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible labels Jan 9, 2020
@mysticatea mysticatea added this to Implemented, pending review in v7.0.0 Jan 14, 2020
@btmills btmills merged commit d86a5bb into master Jan 17, 2020
v7.0.0 automation moved this from Implemented, pending review to Done Jan 17, 2020
@btmills btmills deleted the arraycallback-flatmap branch January 17, 2020 15:59
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 17, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible rule Relates to ESLint's core rules
Projects
No open projects
v7.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants