Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Display pipe character correctly in test output #12771

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix: Display pipe character correctly in test output #12771

merged 1 commit into from
Jan 16, 2020
+15 −1

Conversation

bradzacher
Copy link
Contributor

@bradzacher bradzacher commented Jan 10, 2020 •
edited
Loading

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix (template)

What changes did you make? (Give an overview)

#12031 introduced an invalid regex, which caused the | character to be displayed as \u007c in test output.
This ofc ruins any output with an OR (|| / |). I finally got annoyed enough to look into a fix.

image

This just fixes the output and adds a test to make sure it doesn't happen again.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 10, 2020
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features and removed triage An ESLint team member will look at this issue soon labels Jan 10, 2020
kaicataldo
kaicataldo approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

g-plane
g-plane approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

platinumazure
platinumazure approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@platinumazure platinumazure merged commit 01ff791 into eslint:master Jan 16, 2020
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@bradzacher @montmanu
Fix: Display pipe character correctly in test output (eslint#12771)
16e26e1
@bradzacher bradzacher deleted the fix-pipe-in-test branch March 12, 2020 06:23
@bradzacher bradzacher mentioned this pull request Mar 12, 2020
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 16, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure

@kaicataldo kaicataldo

@g-plane g-plane

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bradzacher @platinumazure @kaicataldo @g-plane