Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: treat comment tokens in template-curly-spacing (fixes #12744) #12775

Merged
merged 1 commit into from Jan 17, 2020
Merged

Update: treat comment tokens in template-curly-spacing (fixes #12744) #12775

merged 1 commit into from Jan 17, 2020

Conversation

yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Jan 11, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

fix #12744 by treating comments as tokens.

Is there anything you'd like reviewers to focus on?

This change will produce new warnings in the cases below.
Can this change be a semver-minor bug fix? Or is it breaking change?

/*eslint template-curly-spacing: ["error", "always"]*/

`${/**/ foo /* */}`

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 11, 2020
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jan 14, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I think this should be treated as a semver-minor bug fix due to the (correct) increase of errors reported. Would you mind updating the message to Update: instead of Fix:?

@yeonjuan
Copy link
Member Author

@kaicataldo
Yes I agree! I'll change the commit message.! thanks.

@yeonjuan yeonjuan changed the title Fix: treat comments as tokens in template-curly-spacing (fixes #12744) Update: treat comment tokens in template-curly-spacing (fixes #12744) Jan 15, 2020
@kaicataldo kaicataldo merged commit f8f115a into eslint:master Jan 17, 2020
@kaicataldo
Copy link
Member

Thanks for contributing!

@yeonjuan yeonjuan deleted the template-curly-spacing-fix-bug branch January 20, 2020 15:59
@btmills btmills mentioned this pull request Mar 26, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 17, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template-curly-spacing fix should not remove comments inside the curly braces.
3 participants