Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Improve sort-keys #12791

Merged
merged 2 commits into from Jan 15, 2020
Merged

Docs: Improve sort-keys #12791

merged 2 commits into from Jan 15, 2020

Conversation

stevenvachon
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
See commit messages

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 14, 2020
@stevenvachon stevenvachon changed the title Improve sort-keys documentation Docs: Improve sort-keys Jan 14, 2020
kaicataldo
kaicataldo approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@kaicataldo kaicataldo added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jan 15, 2020
g-plane
g-plane approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 02fcc05 into eslint:master Jan 15, 2020
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@stevenvachon @montmanu
Docs: Improve sort-keys (eslint#12791)
5557f5d 
* Docs: Improve sort-keys wording

* Docs: Diff sort-keys

… to help sell the feature
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 15, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@g-plane g-plane g-plane approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenvachon @kaicataldo @g-plane