Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add missing plugin reference #12796

Merged
merged 1 commit into from Feb 14, 2020
Merged

Docs: add missing plugin reference #12796

merged 1 commit into from Feb 14, 2020

Conversation

aryzing
Copy link
Contributor

@aryzing aryzing commented Jan 16, 2020

Rules from plugins need to be namespaced using plugin name, which is missing.

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Add missing plugin reference

Is there anything you'd like reviewers to focus on?
no

Rules from plugins need to be namespaced using plugin name, which is missing.
@jsf-clabot
Copy link

jsf-clabot commented Jan 16, 2020

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 16, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo changed the title Add missing plugin reference Docs: add missing plugin reference Jan 16, 2020
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jan 16, 2020
@kaicataldo
Copy link
Member

kaicataldo commented Jan 16, 2020

If you wouldn't mind signing the CLA, we can get this merged!

@kaicataldo
Copy link
Member

Also, whoever merges this should ensure that the squashed merge commit is updated to Docs: add missing plugin reference.

Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add
Copy link
Member

hi, @aryzing thanks for contributing! can you please sign our cla, -- we cannot merge before you have done it.

@btmills btmills merged commit f702b1a into eslint:master Feb 14, 2020
@btmills
Copy link
Member

btmills commented Feb 14, 2020

GitHub encountered an error merging this, and apparently the "Try Again" button in the error box doesn't use the updated commit message, so it's missing the Docs: prefix in master. I'll manually add this to the release notes.

montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
Rules from plugins need to be namespaced using plugin name, which is missing.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 14, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants