Update: fix no-restricted-imports export * false negative (fixes #12737) #12798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
bug
btmills
approved these changes
Jan 17, 2020
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix #12737
This bug fix produces more warnings by default.
What changes did you make? (Give an overview)
The previous behavior was to disallow
export * from "foo"just when the whole module"foo"is restricted.After this fix, the rule will disallow
export * from "foo"even if only some names from"foo"are restricted but not the whole module (i.e., configuration for"foo"hasimportNamesoption).Is there anything you'd like reviewers to focus on?