Update: fix no-magic-numbers false negative with ignoreArrayIndexes #12805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
This bug fix produces more warnings by default.
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo Link
What did you expect to happen?
1 error, since this isn't an array index.
What actually happened? Please include the actual, raw output from ESLint.
No errors.
What changes did you make? (Give an overview)
Added check that the number is
property
, not just any child ofMemberExpression
.Is there anything you'd like reviewers to focus on?
Also added regression tests to make sure that this change doesn't affect behavior when the number is really the
property
, though some of these cases might be another bug. I'll open an issue for these.