Update: check template literal in no-proto, no-iterator (fixes #12801) #12806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
yeonjuan
changed the title
aladdin-add
added
accepted
mdjermanovic
added
the
enhancement
|
I think it's reasonable to treat this as a bug fix because these rules already report Only, the PR title should be |
kaicataldo
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Agreed with @mdjermanovic that this should be a semver-minor bug fix and should be labeled as Update:. Otherwise, LGTM!
yeonjuan
changed the title
|
@kaicataldo Sure, I changed the label, thanks! |
|
Thanks for contributing! |
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
…#12801) (eslint#12806) * Fix: check template literal prop in no-proto (eslint#12801) * Fix: check template literal prop in no-iterator (eslint#12801) * add test cases
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
For checking template literal, also, I change the checking logic to use
getStaticPropertyName()inast-utils.Is there anything you'd like reviewers to focus on?
It needs a consensus of ESlint members. - #12801