Check statically known computed names in no-dupe-class-members

[mdjermanovic]

What rule do you want to change?

no-dupe-class-members

Does this change cause the rule to produce more or fewer warnings?

more

How will the change be implemented? (New option, new default behavior, etc.)?

new default behavior

Maybe as a breaking change in v7.0.0?

Please provide some example code that this change will affect:

class A {
  ["a"](){}
  ["a"](){}
  
  [`b`](){}
  b(){}
}

What does the rule currently do for this code?

no errors

What will the rule do after it's changed?

2 errors, for names "a" and "b".

The proposal is to check all class members for which astUtils.getStaticPropertyName returns a string value and thus align this rule to the similar no-dupe-keys rule:

/*eslint no-dupe-keys: "error"*/
/*eslint no-dupe-class-members: "error"*/

var obj =  {  
  ["a"](){},
  ["a"](){}, // error
  
  [`b`](){},
  b(){} // error
}

class A {
  ["a"](){}
  ["a"](){} // should be error
  
  [`b`](){}
  b(){} // should be error
}

Demo Link

Are you willing to submit a pull request to implement this change?

Yes.

[kaicataldo]

Agreed. I think this should be treated as a breaking bug fix, since we're currently release v7.

[mdjermanovic]

I'm working on this.