Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default value for enforceForClassMembers in computed-property-spacing #12812

Closed
mdjermanovic opened this issue Jan 20, 2020 · 1 comment · Fixed by #12915
Closed

Change default value for enforceForClassMembers in computed-property-spacing #12812

mdjermanovic opened this issue Jan 20, 2020 · 1 comment · Fixed by #12915
Assignees
@mdjermanovic
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue rule Relates to ESLint's core rules
Projects
v7.0.0

Comments

@mdjermanovic
Copy link
Member

Rule: computed-property-spacing

This is a proposal to change the default value for the option enforceForClassMembers to true in v7.0.0

The rule currently checks object literals and member expressions by default.

I believe the expected behavior for this rule would be to check computed names in class definitions by default, too.

The option was added in v6.4.0.
@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules breaking This change is backwards-incompatible evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jan 20, 2020
@mdjermanovic mdjermanovic self-assigned this Jan 20, 2020
@kaicataldo kaicataldo added this to Needs discussion in v7.0.0 Jan 27, 2020
@nzakas nzakas moved this from Needs discussion to Accepted, ready to implement in v7.0.0 Feb 13, 2020
@btmills btmills added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Feb 13, 2020
@btmills
Copy link
Member

btmills commented Feb 13, 2020

In today's TSC meeting, we accepted this as a semver-major change for the v7.0.0 release. It's now ready to implement!

mdjermanovic added a commit that referenced this issue Feb 14, 2020
@mdjermanovic
Breaking: class default true computed-property-spacing (fixes #12812)
d669706
@mdjermanovic mdjermanovic mentioned this issue Feb 14, 2020
Merged
2 tasks
@mysticatea mysticatea moved this from Accepted, ready to implement to Implemented, pending review in v7.0.0 Feb 16, 2020
@mysticatea mysticatea moved this from Implemented, pending review to Issues which have PR in v7.0.0 Feb 16, 2020
@kaicataldo kaicataldo added good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue labels Feb 17, 2020
v7.0.0 automation moved this from Issues which have PR to Done Feb 28, 2020
kaicataldo pushed a commit that referenced this issue Feb 28, 2020
@mdjermanovic
Breaking: class default true computed-property-spacing (fixes #12812)…
afa9aac 
… (#12915)
montmanu pushed a commit to montmanu/eslint that referenced this issue Mar 4, 2020
@mdjermanovic @montmanu
Breaking: class default true computed-property-spacing (fixes eslin…
1b9cc92 
…t#12812) (eslint#12915)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 28, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdjermanovic mdjermanovic

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible good first issue Good for people who haven't worked on ESLint before help wanted The team would welcome a contribution from the community for this issue rule Relates to ESLint's core rules
Projects
No open projects
v7.0.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: class default true computed-property-spacing (fixes #12812) eslint/eslint
3 participants
@btmills @kaicataldo @mdjermanovic