Update: Improve report location for template-curly-spacing #12813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain:
Changes
template-curly-spacing
report locations.What changes did you make? (Give an overview)
${
or}
"always"
before this change:"always"
after this change:"never"
before this change:"never"
after this change:Also:
.startsWith()
and.endsWith()
.isSpaceBetweenTokens
withisSpaceBetween
Is there anything you'd like reviewers to focus on?
prevToken
/nextToken
exists or not are removed. I believe they were not necessary (in the previous version as well) when the template token starts/ends with}
/${
.Marked as an enhancement, as suggested in a similar PR (I agree), but I guess it can be accepted as a bug fix.