Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix anchor links in Node.js API table of contents #12821

Merged
merged 1 commit into from Jan 22, 2020
Merged

Docs: Fix anchor links in Node.js API table of contents #12821

merged 1 commit into from Jan 22, 2020

Conversation

silvenon
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I updated the anchor links in the table of contents in the Node.js API documentation. Most of the links were broken because the autogenerated header links convert # into -.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 22, 2020
@kaicataldo kaicataldo added bug ESLint is working incorrectly documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jan 22, 2020
kaicataldo
kaicataldo approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit aea1729 into eslint:master Jan 22, 2020
@silvenon silvenon deleted the docs/nodejs-api-toc branch January 23, 2020 08:52
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@silvenon @montmanu
Docs: Fix anchor links in Node.js API TOC (eslint#12821)
c6ccf40
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@silvenon @kaicataldo