Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add missing ecmaVersion 2020/11 type value #12833

Merged
merged 1 commit into from Jan 30, 2020
Merged

Chore: add missing ecmaVersion 2020/11 type value #12833

merged 1 commit into from Jan 30, 2020

Conversation

peterblazejewicz
Copy link
Contributor

This is minor fix for shared type definition.

Thanks!

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.
  • Other, please explain: fixes missing type value

@jsf-clabot
Copy link

jsf-clabot commented Jan 27, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 27, 2020
@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jan 27, 2020
@kaicataldo
Copy link
Member

Thanks for the PR! Do you mind signing the CLA as well as updating the commit message to follow our guidelines?

@peterblazejewicz peterblazejewicz changed the title fix(ecmaVersion): add missing 2020/11 type value Fix: add missing ecmaVersion 2020/11 type value Jan 27, 2020
@peterblazejewicz
Copy link
Contributor Author

@kaicataldo somehow messed up with this, sorry for the fuss, updated!

@kaicataldo
Copy link
Member

No worries! Sorry, I should have been clearer about this earlier, but do you mind labeling this as Chore:? Thank you!

@peterblazejewicz
Chore: add missing ecmaVersion 2020/11 type value
c55c7b4 
This is a minor fix for shared type definition.

Thanks!
@peterblazejewicz peterblazejewicz changed the title Fix: add missing ecmaVersion 2020/11 type value Chore: add missing ecmaVersion 2020/11 type value Jan 27, 2020
@peterblazejewicz
Copy link
Contributor Author

Done!

kaicataldo
kaicataldo approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

yeonjuan
yeonjuan approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

platinumazure
platinumazure approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kaicataldo kaicataldo merged commit 691d19a into eslint:master Jan 30, 2020
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

@peterblazejewicz peterblazejewicz deleted the fix/ecmaVersion branch January 30, 2020 21:23
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@peterblazejewicz @montmanu
Chore: add missing ecmaVersion 2020/11 type value (eslint#12833)
be4ea8b 
This is a minor fix for shared type definition.

Thanks!
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 30, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterblazejewicz @jsf-clabot @kaicataldo @platinumazure @yeonjuan