Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add errorOnUnmatchedPattern option to CLIEngine #12834

Merged
merged 1 commit into from Feb 5, 2020
Merged

Docs: add errorOnUnmatchedPattern option to CLIEngine #12834

merged 1 commit into from Feb 5, 2020

Conversation

arthurdenner
Copy link
Contributor

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update
  • Bug fix (template)
  • New rule (template)
  • Changes an existing rule (template)
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

Documented the new errorOnUnmatchedPattern option on CLIEngine.

Is there anything you'd like reviewers to focus on?

Nope.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 27, 2020
@arthurdenner arthurdenner mentioned this pull request Jan 27, 2020
Closed
@kaicataldo kaicataldo added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jan 27, 2020
kaicataldo
kaicataldo approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@nzakas nzakas merged commit 824d235 into eslint:master Feb 5, 2020
@arthurdenner arthurdenner deleted the docs/CLIEngine-errorOnUnmatchedPattern branch February 5, 2020 19:47
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@arthurdenner @montmanu
Docs: add errorOnUnmatchedPattern option to CLIEngine (eslint#12834)
8658d38
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 5, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arthurdenner @kaicataldo @nzakas