Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Node-specific core rules #12835

Closed
kaicataldo opened this issue Jan 27, 2020 · 5 comments · Fixed by #12898
Closed

Deprecate Node-specific core rules #12835

kaicataldo opened this issue Jan 27, 2020 · 5 comments · Fixed by #12898
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects

Comments

@kaicataldo
Copy link
Member

kaicataldo commented Jan 27, 2020

The version of ESLint you are using.
master

The problem you want to solve.

The number of rules in core has grown to the point that we have to set a very high bar for new rules. To improve our ability to maintain core, I think it makes sense to treat the current core Node/CommonJS rules similarly to how we handled the deprecation of core JSDoc rules. I believe these are the last runtime/library specific rules that we have in core, and think this also makes sense for the sake of consistency.

Your take on the correct solution to problem.

As discussed in our TSC meeting (notes here), this proposal is to deprecate all the Node/CommonJS-specific rules in core and to move all of them into eslint-plugin-node, maintained by @mysticatea.

Are you willing to submit a pull request to implement this change?
Yes!

Questions

  1. @mysticatea Are you still okay with this? Just wanted to check because it's been a little while since we last discussed this.
@kaicataldo kaicataldo added enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jan 27, 2020
@kaicataldo kaicataldo added this to Needs discussion in v7.0.0 Jan 27, 2020
@mysticatea
Copy link
Member

Thank you for this issue.

Are you still okay with this? Just wanted to check because it's been a little while since we last discussed this.

Yes!

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Feb 8, 2020
@kaicataldo
Copy link
Member Author

Marking as accepted since this was decided on during a TSC meeting and @mysticatea is still on board.

@kaicataldo
Copy link
Member Author

I'll work on this :)

@kaicataldo
Copy link
Member Author

kaicataldo commented Feb 10, 2020

Steps to complete this:

@kaicataldo kaicataldo added rule Relates to ESLint's core rules and removed core Relates to ESLint's core APIs and features labels Feb 10, 2020
@nzakas nzakas moved this from Needs discussion to Accepted, ready to implement in v7.0.0 Feb 13, 2020
@mysticatea mysticatea moved this from Accepted, ready to implement to Issues which have PR in v7.0.0 Feb 16, 2020
@nzakas nzakas linked a pull request Mar 26, 2020 that will close this issue
2 tasks
@ljharb
Copy link
Sponsor Contributor

ljharb commented Apr 3, 2020

I know it might be late, but this seems like a terrible idea. Having rules in core is paramount for discoverability, especially since shared configs and peer deps are still a huge PITA, until shared configs can bring along plugins as regular deps.

v7.0.0 automation moved this from Issues which have PR to Done Apr 7, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 5, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
No open projects
v7.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants