Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add test for no-constant-condition #12836

Merged
merged 1 commit into from Jan 28, 2020
Merged

Chore: add test for no-constant-condition #12836

merged 1 commit into from Jan 28, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain: Follow-up to #12307

What changes did you make? (Give an overview)

Added a test that verifies that the change from #12307 applies only to binary +.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules chore This change is not user-facing labels Jan 28, 2020
yeonjuan
yeonjuan approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

kaicataldo
kaicataldo approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

@kaicataldo kaicataldo merged commit f5b9656 into master Jan 28, 2020
@kaicataldo kaicataldo deleted the pr12307-followup branch January 28, 2020 15:23
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@mdjermanovic @montmanu
Chore: add test for no-constant-condition (eslint#12836)
bf353bf
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 28, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdjermanovic @kaicataldo @yeonjuan