Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add missing eslint comments in prefer-regex-literals examples #12858

Merged
merged 1 commit into from Feb 3, 2020
Merged

Docs: add missing eslint comments in prefer-regex-literals examples #12858

merged 1 commit into from Feb 3, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update

What changes did you make? (Give an overview)

Added /*eslint prefer-regex-literals: "error"*/ in the examples, missed that in the original PR.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Feb 1, 2020
yeonjuan
yeonjuan approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! 👍

@kaicataldo kaicataldo merged commit d6c313d into master Feb 3, 2020
@kaicataldo kaicataldo deleted the preferregex-eslintindocs branch February 3, 2020 16:08
@kaicataldo
Copy link
Member

Nice catch! Thanks for contributing.

montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@mdjermanovic @montmanu
Docs: add missing eslint comments in prefer-regex-literals examples (e…
61416b0 
…slint#12858)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 3, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdjermanovic @kaicataldo @yeonjuan