New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix spelling mistakes #12861
Docs: Fix spelling mistakes #12861
Conversation
Thanks for fixing all these! I just changed the title to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in the first iteration, aside from just one detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just, I don't know should those 3 bench/performance files remain unchanged (incl. missing eols at the end) for some reason:
- tests/bench/large.js
- tests/bench/small.js
- tests/performance/jshint.js
Thanks for working on this! I think it's probably best not to change the three test files listed above by @mdjermanovic. Otherwise, this LGTM! |
Thanks for reviewing. I removed the changes to those 3 files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing I missed the first time. Sorry! Otherwise, LGTM.
I searched for typos / spelling mistake using cspell. I manually fixed the obvious typos that were reported (and ignored thousands of other false positive matches).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and for prompty responding to the feedback!
Edit: *promptly. Leaving it as is because it's too ironic not to.
Thanks for contributing to ESLint! |
I searched for typos / spelling mistake using cspell. I manually fixed the obvious typos that were reported (and ignored thousands of other false positive matches).
Searched using cspell. I manually fixed the obvious typos while ignoring thousands of false positives.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I searched for typos / spelling mistake using cspell. I manually fixed the obvious typos that were reported (and ignored thousands of other false positive matches).
Is there anything you'd like reviewers to focus on?
No.