Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix spelling mistakes #12861

Merged
merged 1 commit into from Feb 4, 2020
Merged

Docs: Fix spelling mistakes #12861

merged 1 commit into from Feb 4, 2020

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Feb 1, 2020

Searched using cspell. I manually fixed the obvious typos while ignoring thousands of false positives.

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I searched for typos / spelling mistake using cspell. I manually fixed the obvious typos that were reported (and ignored thousands of other false positive matches).

Is there anything you'd like reviewers to focus on?

No.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 1, 2020
@bmish bmish changed the title Fix spelling mistakes Chore: Fix spelling mistakes Feb 1, 2020
@bmish bmish requested review from kaicataldo, mysticatea and mdjermanovic and removed request for kaicataldo February 2, 2020 01:58
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Feb 2, 2020
@mdjermanovic mdjermanovic changed the title Chore: Fix spelling mistakes Docs: Fix spelling mistakes Feb 2, 2020
@mdjermanovic
Copy link
Member

Thanks for fixing all these!

I just changed the title to Docs: because some of the changes are in the user-facing documentation.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the first iteration, aside from just one detail.

docs/rules/no-fallthrough.md Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just, I don't know should those 3 bench/performance files remain unchanged (incl. missing eols at the end) for some reason:

  • tests/bench/large.js
  • tests/bench/small.js
  • tests/performance/jshint.js

@kaicataldo
Copy link
Member

Thanks for working on this! I think it's probably best not to change the three test files listed above by @mdjermanovic. Otherwise, this LGTM!

@bmish
Copy link
Sponsor Member Author

bmish commented Feb 4, 2020

Thanks for reviewing. I removed the changes to those 3 files.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing I missed the first time. Sorry! Otherwise, LGTM.

lib/rules/no-unused-vars.js Outdated Show resolved Hide resolved
I searched for typos / spelling mistake using cspell. I manually fixed the obvious typos that were reported (and ignored thousands of other false positive matches).
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and for prompty responding to the feedback!

Edit: *promptly. Leaving it as is because it's too ironic not to.

@kaicataldo kaicataldo merged commit 33efd71 into eslint:master Feb 4, 2020
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
I searched for typos / spelling mistake using cspell. I manually fixed the obvious typos that were reported (and ignored thousands of other false positive matches).
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 4, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants