Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add Twitter and Open Collective badge #12877

Merged
merged 6 commits into from Feb 6, 2020
Merged

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Feb 5, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Chore

What changes did you make? (Give an overview)

This PR adds an Open Collective badge and reorders the badges in groupings that I think make more sense.

Is there anything you'd like reviewers to focus on?

  1. Does this make sense?
  2. Do we need the bounty source badge? I've never actually seen a bounty paid out, and it's adding noise to the line of current more-relevant badges.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 5, 2020
@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Feb 5, 2020
@kaicataldo kaicataldo changed the title Chore: add Open Collective badge Chore: add Twitter and Open Collective badge Feb 5, 2020
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo.

README.md Outdated
@@ -32,7 +35,7 @@ ESLint is a tool for identifying and reporting on patterns found in ECMAScript/J
5. [Frequently Asked Questions](#faq)
6. [Releases](#releases)
7. [Semantic Versioning Policy](#semantic-versioning-policy)
8. [License](#license)
8. [License](#license
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Thanks!

@nzakas nzakas merged commit 1907e57 into master Feb 6, 2020
@nzakas nzakas deleted the kaicataldo-oc-badge branch February 6, 2020 20:19
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
* Chore: add Open Collective badge

* Add Twitter badge

* Split Open Collective badges into backers and sponsors

* Update README.md

* Reorder once more

* Fix typo
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 6, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants