Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change error message logic for implicit file ignore (fixes #12873) #12878

Merged
merged 1 commit into from Mar 28, 2020

Conversation

snhardin
Copy link
Contributor

@snhardin snhardin commented Feb 6, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Addresses issue #12873

What changes did you make? (Give an overview)

I adjusted the logic that determines what message to send when a file is ignored.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 6, 2020
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features and removed triage An ESLint team member will look at this issue soon labels Feb 7, 2020
@kaicataldo
Copy link
Member

Copying from this comment:

I wonder if it would be helpful to differentiate between when a file is ignored due to it being in a dotfolder versus it being a dotfile?

@nzakas
Copy link
Member

nzakas commented Feb 7, 2020

@kaicataldo can you be more specific with your feedback? Are you requesting a change in this PR or just asking for an opinion?

@kaicataldo
Copy link
Member

Sure thing - sorry for the confusion. My comment wasn't intended to be a blocker. It was just an idea I thought might improve the user experience a bit. Looking at it again, though, I think the current error message is sufficient 👍.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment for clarity, but otherwise this LGTM!

lib/cli-engine/cli-engine.js Outdated Show resolved Hide resolved
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks!

@kaicataldo kaicataldo merged commit 29f32db into eslint:master Mar 28, 2020
@kaicataldo
Copy link
Member

Thank you for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 25, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants