New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Change error message logic for implicit file ignore (fixes #12873) #12878
Conversation
Copying from this comment: I wonder if it would be helpful to differentiate between when a file is ignored due to it being in a dotfolder versus it being a dotfile? |
@kaicataldo can you be more specific with your feedback? Are you requesting a change in this PR or just asking for an opinion? |
Sure thing - sorry for the confusion. My comment wasn't intended to be a blocker. It was just an idea I thought might improve the user experience a bit. Looking at it again, though, I think the current error message is sufficient 👍. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment for clarity, but otherwise this LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks!
Thank you for contributing! |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Addresses issue #12873
What changes did you make? (Give an overview)
I adjusted the logic that determines what message to send when a file is ignored.
Is there anything you'd like reviewers to focus on?