Update: check renaming identifier in object destructuring (fixes 12827) #12881

yeonjuan · 2020-02-06T18:14:23Z

Prerequisites checklist

I have read the contributing guidelines.
The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

const { renamed: renaming} = foo;

Changed this rule to warn the length of the renaming identifier rather than a renamed identifier.

Is there anything you'd like reviewers to focus on?

Fixes #12827

lib/rules/id-length.js

tests/lib/rules/id-length.js

docs/rules/id-length.md

tests/lib/rules/id-length.js

mdjermanovic

@yeonjuan sorry for the confusion, I didn't mean to suggest to fix these 3 issues now.

Since you already fixed that, I think that 2 of those 3 changes are certainly correct at this moment.

var {x} = foo; might need a discussion as it could be undesirable for some users.

I left comments on tests cases for these 3 changes.

tests/lib/rules/id-length.js

mdjermanovic · 2020-02-10T20:12:05Z

Checked examples from the docs:

var { a: [x]} = {}; examples will be valid after this PR (without the other PR), maybe we should remove them from invalid sections, in this PR.
var { prop: a } = {}; in section Examples of incorrect code for this rule with the { "min": 4 } option: is now invalid.
In the same section, var foo = function (event) { /* do stuff */ }; is also invalid. that was probably a mistake in the docs.
In the same section, obj.element = document.body; and ({ prop: obj.name } = {}); are both invalid on obj. That was probably broken in the code. Not sure what should we do with this, maybe leave for another PR.

mdjermanovic

LGTM, thanks!

tests/lib/rules/id-length.js

kaicataldo · 2020-02-16T04:39:05Z

docs/rules/id-length.md

@@ -89,8 +91,7 @@ class x { }
 class Foo { x() {} }
 function foo(...x) { }
 var { x } = {};
-var { x: a} = {};
-var { a: [x]} = {};


Is this a regression in this PR? I see that this is going to be worked on in a separate PR. Do we have an issue outlining our plan for this (just in case someone else needs to pick this work up)?

@kaicataldo

Is this a regression in this PR?

Yes. The case will not be warned after this PR merged because the actual version warns about a rather than x.

Online Demo

/*eslint id-length: ["error", { "min": 4 }]*/ /*eslint-env es6*/ var { a: [x]} = {}; // Error: Identifier name `a` ...

And there is a PR working on to fix it (#12839).

Do we have an issue outlining our plan for this (just in case someone else needs to pick this work up)?

I will add an outlining plan for this on #12832. Thanks 👍

kaicataldo · 2020-02-16T04:39:51Z

Thanks for working on this!

kaicataldo · 2020-02-17T17:06:22Z

Thanks for contributing!

…7) (eslint#12881) * Update: check renaming identifier in object destructuring (fixes 12827) * Fix wrong error type * ignore properties options on object pattern, ignore computed prop * modify docs, add test cases * add test cases * remove wrong test cases * change to ignore destructuring on properties never * update documentation * fix typo * fix documentation * include error loc, data info

yeonjuan added 2 commits February 7, 2020 03:03

Update: check renaming identifier in object destructuring (fixes 12827)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

4ad9e98

Fix wrong error type

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

213b236

eslint-deprecated bot added the triage label Feb 6, 2020

yeonjuan added accepted bug enhancement rule and removed triage labels Feb 6, 2020

mdjermanovic reviewed Feb 6, 2020

View reviewed changes

lib/rules/id-length.js Outdated Show resolved Hide resolved

mdjermanovic requested changes Feb 7, 2020

View reviewed changes

yeonjuan added 4 commits February 7, 2020 21:17

ignore properties options on object pattern, ignore computed prop

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

ce40f92

modify docs, add test cases

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

6c235de

add test cases

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

ed2485d

remove wrong test cases

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

c22fe9c

mdjermanovic reviewed Feb 10, 2020

View reviewed changes

tests/lib/rules/id-length.js Show resolved Hide resolved

tests/lib/rules/id-length.js Outdated Show resolved Hide resolved

tests/lib/rules/id-length.js Outdated Show resolved Hide resolved

yeonjuan added 3 commits February 11, 2020 23:33

update documentation

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

54ee384

fix typo

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

a644b11

fix documentation

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

81dc86c

mdjermanovic approved these changes Feb 12, 2020

View reviewed changes

kaicataldo reviewed Feb 16, 2020

View reviewed changes

include error loc, data info

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

486b642

kaicataldo approved these changes Feb 17, 2020

View reviewed changes

kaicataldo merged commit 77df505 into master Feb 17, 2020

kaicataldo deleted the issue12827 branch February 17, 2020 17:06

kaicataldo mentioned this pull request Feb 17, 2020

Update: check identifier in array pattern in id-length (fixes #12832) #12839

Merged

2 tasks

yeonjuan mentioned this pull request Feb 18, 2020

id-length does not check identifier in array pattern #12832

Closed

eslint-deprecated bot locked and limited conversation to collaborators Aug 17, 2020

eslint-deprecated bot added the archived due to age label Aug 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

Update: check renaming identifier in object destructuring (fixes 12827) #12881

Update: check renaming identifier in object destructuring (fixes 12827) #12881

yeonjuan commented Feb 6, 2020 •

edited

Loading

mdjermanovic left a comment

mdjermanovic commented Feb 10, 2020

mdjermanovic left a comment

kaicataldo Feb 16, 2020

yeonjuan Feb 16, 2020 •

edited

Loading

kaicataldo commented Feb 16, 2020

kaicataldo commented Feb 17, 2020

Update: check renaming identifier in object destructuring (fixes 12827) #12881

Update: check renaming identifier in object destructuring (fixes 12827) #12881

Conversation

yeonjuan commented Feb 6, 2020 • edited Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

mdjermanovic left a comment

Choose a reason for hiding this comment

mdjermanovic commented Feb 10, 2020

mdjermanovic left a comment

Choose a reason for hiding this comment

kaicataldo Feb 16, 2020

Choose a reason for hiding this comment

yeonjuan Feb 16, 2020 • edited Loading

Choose a reason for hiding this comment

kaicataldo commented Feb 16, 2020

kaicataldo commented Feb 17, 2020

yeonjuan commented Feb 6, 2020 •

edited

Loading

yeonjuan Feb 16, 2020 •

edited

Loading