yoda rule exceptRange false positives

[mdjermanovic]

Tell us about your environment

• ESLint Version: 7.0.0-alpha.0
• Node Version: v12.14.0
• npm Version: v6.13.4

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

module.exports = {
    parserOptions: {
        ecmaVersion: 2015
    },
};

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

These are two different issues.

1. Possible inconsistency between "never" and "always".

Demo

/* eslint yoda: ["error", "never", { exceptRange: true }] */

if (0 < x && x < something) {} // no error

Demo

/* eslint yoda: ["error", "always", { exceptRange: true }] */

if (something < x && x < 100 ) {} // error on x < 100

2. Possible inconsistency between how the rule treats numbers and strings.

Demo

/* eslint yoda: ["error", "never", { exceptRange: true }] */

if (1 < x && x < MAX ) {} // no error

if ("a" < x && x < MAX ) {} // error on "a" < x

eslint index.js

What did you expect to happen?

Maybe no errors.

What actually happened? Please include the actual, raw output from ESLint.

Two errors noted in the comments.

Are you willing to submit a pull request to fix this bug?

Yes.

[kaicataldo]

These both looks like bugs to me 👍

Can we split this into two issues (or at least implement them in separate PRs)?

[anikethsaha]

@mdjermanovic

for this example

/* eslint yoda: ["error", "always", { exceptRange: true }] */

if (something < x && x < 100 ) {} // error on x < 100

exceptRange options is for never right !, so when testing it with never its lint free

demo

[mdjermanovic]

exceptRange options is for never right

That's indeed what documentation says:

The default "never" option can have exception options in an object literal

However, that text was added later in #5596.

By the original issue #1561 and PR #1570 it doesn't seem that the exceptRange option was meant to apply to "never" only.

Also, the same sentence in documentation is incorrect for the "onlyEquality" option, because it does apply to "always" as well:

/*eslint yoda: ["error", "always", { "onlyEquality": true }]*/

if (x < 1) {} // no error

[anikethsaha]

thanks for the info.
👍

I will try to fix the 2nd issue (2. Possible inconsistency between how the rule treats numbers and strings. ) through #13052