Fix: arrow-body-style crash with object literal body (fixes #12884) #12886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Bug fix
Fixes #12884
arrow-body-style
autofix crashes or produces invalid code while trying to convert object literal expression body to a block body, whenever(
and{
are not adjacent:() => ({})
() => ( {})
Demo(() => ( {}))
fixed to(() => {return {})}
DemoWhat changes did you make? (Give an overview)
Fixed to code to pass the brace token instead of the paren token to
sourceCode#getNodeByRangeIndex
Is there anything you'd like reviewers to focus on?
In this branch, auto-fixer has also to account for the ASI (it used to crash in all situations where ASI can happen, so it wasn't observable). In particular, for a code where
(
and{
are not on the same line. This is solved by replacing(
with a block{
and insertingreturn
before the object's{
. Is it okay?The code from the original issue:
will be auto-fixed to: