Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make YieldExpression throwable (fixes #12880) #12897

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

yeonjuan
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Changed code-path-analyzer to treat YieldExpression as a throwable.

Is there anything you'd like reviewers to focus on?

It will fix #12880
Are there any other rules affected by this change except no-unreachable.?
I searched, but could not find. If I missed something, please tell me. Thanks : )

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 10, 2020
@yeonjuan yeonjuan added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Feb 10, 2020
@mdjermanovic mdjermanovic added the core Relates to ESLint's core APIs and features label Feb 10, 2020
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to get a review from @mysticatea too.

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@btmills btmills merged commit b5adcaa into master Feb 14, 2020
@btmills btmills deleted the issue12880 branch February 14, 2020 15:54
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 14, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive no-unreachable catch in generator
5 participants